Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure valid entity alias names created for projected volume tokens. #137

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Feb 15, 2022

Overview

Validate the entity alias name for projected volume tokens when the role's alias_name_source is configured as serviceaccount_name

Add tests.

@benashz benashz requested review from tomhjp and tvoran February 15, 2022 16:00
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Left a couple questions in the test, but nothing worth blocking this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants