[VAULT-33207] Update Policy Modal links to use HDS, add ACL Policies …

…"get started" link (#29254) * [VAULT-33207] Update Policy Modal links to use HDS, add ACL Policies "get started" link * fix failing test
hashicorp · Dec 26, 2024 · 28768d5 · 28768d5
1 parent 847597f
commit 28768d5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/ui/lib/core/addon/components/policy-example.hbs b/ui/lib/core/addon/components/policy-example.hbs
@@ -6,15 +6,16 @@
 <div class="has-bottom-margin-s">
   {{#if (eq @policyType "acl")}}
     <p data-test-example-modal-text="acl">
-      ACL Policies are written in Hashicorp Configuration Language (
-      <ExternalLink @href="https://github.com/hashicorp/hcl">HCL</ExternalLink>
+      <Hds::Link::Inline @href={{doc-link "/vault/tutorials/get-started/introduction-policies"}}>ACL Policies</Hds::Link::Inline>
+      are written in Hashicorp Configuration Language (
+      <Hds::Link::Inline @href="https://github.com/hashicorp/hcl">HCL</Hds::Link::Inline>
       ) or JSON and describe which paths in Vault a user or machine is allowed to access. Here is an example policy:
     </p>
   {{else if (eq @policyType "rgp")}}
     <p class="has-bottom-margin-s" data-test-example-modal-text="rgp">
       Role Governing Policies (RGPs) are tied to client tokens or identities which is similar to
-      <DocLink @path="/vault/tutorials/policies/policies">ACL policies</DocLink>. They use
-      <DocLink @path="/vault/docs/enterprise/sentinel">Sentinel</DocLink>
+      <Hds::Link::Inline @href={{doc-link "/vault/tutorials/policies/policies"}}>ACL policies</Hds::Link::Inline>. They use
+      <Hds::Link::Inline @href={{doc-link "/vault/docs/enterprise/sentinel"}}>Sentinel</Hds::Link::Inline>
       as a language framework to enable fine-grained policy decisions.
     </p>
     <p>
@@ -31,9 +32,9 @@
       Endpoint Governing Policies (EGPs) are tied to particular paths (e.g.
       <code class="tag is-marginless is-paddingless">aws/creds/</code>
       ) instead of tokens. They use
-      <ExternalLink @href="https://docs.hashicorp.com/sentinel/language">Sentinel</ExternalLink>
+      <Hds::Link::Inline @href="https://docs.hashicorp.com/sentinel/language">Sentinel</Hds::Link::Inline>
       as a language to access
-      <DocLink @path="/vault/docs/enterprise/sentinel/properties">properties</DocLink>
+      <Hds::Link::Inline @href={{doc-link "/vault/docs/enterprise/sentinel/properties"}}>properties</Hds::Link::Inline>
       of the incoming requests.
     </p>
     <p>
@@ -55,8 +56,11 @@
     More information about
     {{uppercase @policyType}}
     policies can be found
-    <DocLink @path={{get this.moreInformationLinks @policyType}} data-test-example-modal-information-link>
+    <Hds::Link::Inline
+      @href={{doc-link (get this.moreInformationLinks @policyType)}}
+      data-test-example-modal-information-link
+    >
       here.
-    </DocLink>
+    </Hds::Link::Inline>
   </p>
 </div>
diff --git a/ui/tests/integration/components/policy-example-test.js b/ui/tests/integration/components/policy-example-test.js
@@ -50,7 +50,7 @@ module('Integration | Component | policy-example', function (hooks) {
     assert
       .dom(SELECTORS.policyDescription('rgp'))
       .hasText(
-        'Role Governing Policies (RGPs) are tied to client tokens or identities which is similar to ACL policies . They use Sentinel as a language framework to enable fine-grained policy decisions.'
+        'Role Governing Policies (RGPs) are tied to client tokens or identities which is similar to ACL policies. They use Sentinel as a language framework to enable fine-grained policy decisions.'
       );
   });