Remove oracle banner (#19532)

* remove oracle banner * add back extra test coverage for other banner * add description
hashicorp · Mar 17, 2023 · aaf2824 · aaf2824
1 parent e210cae
commit aaf2824
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 21 deletions.
diff --git a/changelog/19019.txt b/changelog/19019.txt
diff --git a/ui/app/templates/components/database-connection.hbs b/ui/app/templates/components/database-connection.hbs
@@ -160,18 +160,7 @@
         {{/if}}
       </div>
     {{/unless}}
-    {{#if (eq @model.plugin_name "vault-plugin-database-oracle")}}
-      <AlertBanner
-        @type="info"
-        @title="Connecting using SSL or TNS Names"
-        @message="To create database connections using SSL or TNS names you may need to provide additional Oracle configuration files for your Vault cluster. If you have already provided these files, they may need to updated if you are creating connections to database hosts not covered by the existing configuration files."
-      >
-        <DocLink @path="/vault/docs/secrets/databases/oracle">
-          <Icon @name="learn-link" />
-          Oracle Database Secrets Engine
-        </DocLink>
-      </AlertBanner>
-    {{/if}}
+
     <div class="field is-grouped is-grouped-split is-fullwidth box is-bottomless">
       <div class="field is-grouped">
         <div class="control">

diff --git a/ui/tests/acceptance/secrets/backend/database/secret-test.js b/ui/tests/acceptance/secrets/backend/database/secret-test.js
@@ -270,7 +270,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
   });
 
   test('Connection create and edit form for each plugin', async function (assert) {
-    assert.expect(169);
+    assert.expect(161);
     const backend = await mount();
     for (const testCase of connectionTests) {
       await connectionPage.visitCreate({ backend });
@@ -293,11 +293,6 @@ module('Acceptance | secrets/database/*', function (hooks) {
         testCase.requiredFields(assert, testCase.name);
         continue;
       }
-      if (testCase.plugin !== 'vault-plugin-database-oracle') {
-        assert
-          .dom('[data-test-alert-banner="alert"]')
-          .doesNotExist('Does not show alert-banners specific only to the Oracle db.');
-      }
       testCase.requiredFields(assert, testCase.name);
       await connectionPage.toggleVerify();
       await connectionPage.save();