Remove attach_workspace that I don't think does anything for us. Use … (

#13418)

Use a new cache key since any old cache entries use the wrong path.

.circleci/config/commands/@caches.yml

@@ -12,14 +12,15 @@ save_yarn_cache:
           - ui/node_modules
 # allows restoring go mod caches by incomplete prefix. This is useful when re-generating
 # cache, but not when running builds and tests that require an exact match.
+# TODO should we be including arch in cache key?
 restore_go_mod_cache_permissive:
   steps:
     - restore_cache:
         name: Restore closest matching go modules cache
         keys:
-          - &gocachekey v1.3-{{checksum "go.sum"}}-{{checksum "sdk/go.sum"}}-{{checksum "api/go.sum"}}
-          -             v1.3-{{checksum "go.sum"}}-{{checksum "sdk/go.sum"}}
-          -             v1.3-{{checksum "go.sum"}}
+          - &gocachekey v1.4-{{checksum "go.sum"}}-{{checksum "sdk/go.sum"}}-{{checksum "api/go.sum"}}
+          -             v1.4-{{checksum "go.sum"}}-{{checksum "sdk/go.sum"}}
+          -             v1.4-{{checksum "go.sum"}}
 restore_go_mod_cache:
   steps:
     - restore_cache:

.circleci/config/jobs/test-go.yml

@@ -3,8 +3,6 @@ parallelism: 8
 steps:
   - exit-if-ui-or-docs-branch
   - checkout
-  - attach_workspace:
-      at: /home/circleci/go/bin
   - go_test:
       log_dir: "/tmp/testlogs"
   - store_artifacts: