UI: Replace instances of <table> with <HDS::Table> #24257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
zofskeez
approved these changes
Nov 27, 2023
| {{#if this.useServiceWorker}} | ||
| <dd.Interactive | ||
| @href="/v1/sys/storage/raft/snapshot" | ||
| @isHrefExternal={{false}} |
There was a problem hiding this comment.
I think false is the component default
There was a problem hiding this comment.
Disregard. The docs show false as default and then contradict that by saying "we add the target="_blank" and rel="noopener noreferrer" attributes to it by default".
Comment on lines
-6
to
-54
| <PageHeader as |p|> | ||
| <p.levelLeft> | ||
| <h1 class="title is-3"> | ||
| Raft Storage | ||
| </h1> | ||
| </p.levelLeft> | ||
| </PageHeader> | ||
| <Toolbar> | ||
| <ToolbarActions> | ||
| <BasicDropdown @class="popup-menu" @horizontalPosition="auto-right" @verticalPosition="below" as |D|> | ||
| <D.Trigger | ||
| data-test-popup-menu-trigger="true" | ||
| class={{concat "toolbar-link" (if D.isOpen " is-active")}} | ||
| @htmlTag="button" | ||
| > | ||
| Snapshots | ||
| <Chevron @direction="down" @isButton={{true}} /> | ||
| </D.Trigger> | ||
| <D.Content @defaultClass="popup-menu-content"> | ||
| <nav class="box menu" aria-label="snapshots actions"> | ||
| <ul class="menu-list"> | ||
| <li class="action"> | ||
| {{#if this.useServiceWorker}} | ||
| <ExternalLink | ||
| @href="/v1/sys/storage/raft/snapshot" | ||
| @sameTab={{true}} | ||
| onclick={{queue (action "downloadViaServiceWorker") (action D.actions.close)}} | ||
| > | ||
| Download | ||
| </ExternalLink> | ||
| {{else}} | ||
| <Hds::Button | ||
| @text="Download" | ||
| class="link" | ||
| {{on "click" (queue (action "downloadSnapshot") (action D.actions.close))}} | ||
| /> | ||
| {{/if}} | ||
| </li> | ||
| <li class="action"> | ||
| <LinkTo @route="vault.cluster.storage-restore"> | ||
| Restore | ||
| </LinkTo> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </D.Content> | ||
| </BasicDropdown> | ||
| </ToolbarActions> | ||
| </Toolbar> |
There was a problem hiding this comment.
So much nicer with Hds PageHeader and Dropdown! 🎉
| /> | ||
| {{else}} | ||
| <p class="has-text-grey">URL unavailable</p> |
There was a problem hiding this comment.
Nice adding a placeholder!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only had 3 places where we used the table tag, all of which are shown below with before/after:
Raft Storage
Before:
After:
DR Known Secondaries
Before:
After:
Performance Secondary primary clusters table
Before:
After: