Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing LDAP test with new attribute #24273

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Nov 28, 2023

This PR address two sets of Failures for enterprise test:

  1. LDAP failure. I believe this failure started because of this PR which appears to add Password Policy to the LDAP configuration Open API.

  2. Replication. Due to this PR.

Locally, now all enterprise tests are passing.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 28, 2023
@Monkeychip Monkeychip added this to the 1.16.0-rc1 milestone Nov 28, 2023
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🚀

@Monkeychip Monkeychip enabled auto-merge (squash) November 28, 2023 17:43
@Monkeychip Monkeychip merged commit e9f7c5b into main Nov 28, 2023
@Monkeychip Monkeychip deleted the ui/LDAP-enterprise-test-failure branch November 28, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants