Updated show lease with toggle ttl picker #11256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For lease renewal, pass increment param instead of interval
arnav28
force-pushed
the
ui/lease-ttl-picker
branch
from
8b6fbc9 to
7f793b5
Compare
chelshaw
suggested changes
Apr 2, 2021
| @labelClass="is-label" | ||
| @onChange={{action (mut increment)}} @unit="s" | ||
| /> | ||
| <div class="field has-top-margin-s"> |
There was a problem hiding this comment.
nit: spacing on this div should be inline with the TTL picker above (since that one is self-closing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2021-04-02.at.11.24.24.AM.mov