Bug Fix: OIDC with hcp flag #11283
Merged
Bug Fix: OIDC with hcp flag #11283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
commented
Apr 6, 2021
| @@ -131,7 +132,7 @@ export default Component.extend({ | |||
| // The namespace can be either be passed as a query paramter, or be embedded | |||
| // in the state param in the format `<state_id>,ns=<namespace>`. So if | |||
| // `namespace` is empty, check for namespace in state as well. | |||
| if (namespace === '') { | |||
| if (namespace === '' || this.featureFlagService.managedNamespaceRoot) { | |||
There was a problem hiding this comment.
see here in code for what this returns.
Monkeychip
added a commit
that referenced
this pull request
Apr 7, 2021
* add conditional * add changelog
Monkeychip
added a commit
that referenced
this pull request
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue using OIDC when coming from a Vault HCP cluster. This PR fixes that by adding a conditional using the feature-flag service.
Tested locally by flipping the flag.