On lease deletion, also delete non-orphan batch token parent index #11377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries for non-orphan batch tokens.
…remove the index entry.
ncabatoff
changed the title
|
Fixes #11178 |
vishalnayak
reviewed
Apr 16, 2021
| @@ -1160,7 +1170,6 @@ func (ts *TokenStore) lookupBatchToken(ctx context.Context, id string) (*logical | |||
| } | |||
| } | |||
|
|
|||
| te.ID = id | |||
There was a problem hiding this comment.
I wonder why this was here in the first place.
There was a problem hiding this comment.
Oh, you have moved this to the internal func. Cool.
vishalnayak
approved these changes
Apr 16, 2021
briankassouf
approved these changes
Apr 16, 2021
HridoyRoy
approved these changes
Apr 16, 2021
ncabatoff
added a commit
that referenced
this pull request
Apr 16, 2021
ncabatoff
added a commit
that referenced
this pull request
Apr 16, 2021
ncabatoff
added a commit
that referenced
this pull request
Apr 19, 2021
ncabatoff
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ries for non-orphan batch tokens.