Bootstrap Nomad ACL system if no token is given #12451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mongey are you still interested in working on this PR? |
Mongey
force-pushed
the
cm-nomad-bootstrap
branch
from
a90860f
to
4cf01e3
Compare
|
@hghaf099 yep |
Mongey
force-pushed
the
cm-nomad-bootstrap
branch
from
5bd5a77
to
7b2eb0d
Compare
Mongey
force-pushed
the
cm-nomad-bootstrap
branch
from
7b2eb0d
to
1ca413b
Compare
|
bump |
swenson
reviewed
Apr 19, 2022
Similar to the [Bootstrap the Consul ACL system if no token is given][boostrap-consul] it would be very useful to bootstrap Nomads ACL system and manage it in Vault. [boostrap-consul]:hashicorp#10751
Mongey
force-pushed
the
cm-nomad-bootstrap
branch
from
1ca413b
to
105b898
Compare
swenson
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
LGTM
I pulled it down and tested it locally. It seems to simplify the process of getting it to work locally, i.e., I can now just run
# window 1
sudo nomad agent -dev -bind 0.0.0.0 -log-level INFO -acl-enabled
# window 2
vault server -dev
# window 3
vault secrets enable nomad
vault write nomad/config/access address=http://127.0.0.1:4646
vault write nomad/role/monitoring policies=readonly
vault read nomad/creds/monitoringAnd skip having to run nomad acl boostrap. Though if we do still run nomad acl boostrap manually, as before, it works as expected.
Thanks so much for your contribution!
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Bootstrap Nomad ACL system if no token is given Similar to the [Bootstrap the Consul ACL system if no token is given][boostrap-consul] it would be very useful to bootstrap Nomads ACL system and manage it in Vault. [boostrap-consul]:#10751 * Add changelog entry * Remove debug log line * Remove redundant else * Rename Nomad acl bootstrap param * Replace sleep with attempt to list nomad leader, setup will retry until successful * fmt
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
* Bootstrap Nomad ACL system if no token is given Similar to the [Bootstrap the Consul ACL system if no token is given][boostrap-consul] it would be very useful to bootstrap Nomads ACL system and manage it in Vault. [boostrap-consul]:#10751 * Add changelog entry * Remove debug log line * Remove redundant else * Rename Nomad acl bootstrap param * Replace sleep with attempt to list nomad leader, setup will retry until successful * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the Bootstrap the Consul ACL system if no token is given
it would be very useful to bootstrap Nomads ACL system and manage it in
Vault.