Include generated ui files in git repo.

[heppu]

As described in #12507 when //go:embed is used Go expects those files to be available in repository. If the files are not available that becomes a problem when we try to vendor the package as dependency.

This PR should include two things:

• commit http/web_ui directory in git repository
• validate in CI that those files have not been edited manually

For the validation part in CI we could do following:

1. make static-dist
2. git diff --name-status --exit-code -- ./http/web_ui

I'm not too familiar with Vault CI pipe and not sure what would the correct place for this so any suggestions would be really helpfull. Ideally the UI files would be already generated in CI pipe and we would only need to check with git command that nothing actually changed.

[hashicorp-cla]

All committers have signed the CLA.

[pmmukh]

Hi @heppu ! Thanks for raising this PR! After taking a look at it, we don't feel like having these files added to Vault is a path we want to go down, with 70 something files it causes unnecessary bloat to the repo to support something we don't intend to support ( vendoring vault as a go module ). As such, I'm going to go ahead and close this PR out.

[heppu]

Sure I can understand that. @pmmukh How would you feel about having that folder with single place holder file? That way it wouldn't bloat the repo, no need to modify tooling and vendoring would work?

[pmmukh]

That honestly seems like a bit of a hacky workaround, and not something we'd like to keep around. I would recommend that for now you depend on an older version of vault that works for vendoring. If you need to both use go 1.17 (as I saw mentioned in your issue) and use vault as a vendored dependency, I'm sorry but I don't think that will be possible.