VAULT 2844: remove legacy lease revocation strategy #12888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Oct 20, 2021
vishalnayak
approved these changes
Oct 20, 2021
|
Can VAULT_16_REVOKE_PERMITPOOL be removed at the same time? Doesn't do anything anymore right? |
|
@ncabatoff i think that's reasonable. okay to do in a separate PR, or do you think it makes more sense as a combo? |
I don't see any reason to keep it around when it doesn't do anything, and it's not like it's going to make the PR much bigger to include that. So I'd prefer to see both tackled here. |
|
@ncabatoff updated! |
ncabatoff
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.