Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry to Vault agent #13675

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Add telemetry to Vault agent #13675

merged 5 commits into from
Feb 18, 2022

Conversation

remilapeyre
Copy link
Contributor

This patch adds a new /agent/v1/metrics that will return metrics on the
running Vault agent. Configuration is done using the same telemetry
stanza than the Vault server. For now default runtime metrics are
returned with a few additional ones specific to the agent:

  • vault.agent.auth.failure and vault.agent.auth.success to monitor
    the correct behavior of the auto auth mechanism
  • vault.agent.proxy.success, vault.agent.proxy.client_error and
    vault.agent.proxy.error to check the connection with the Vault server
  • vault.agent.cache.hit and vault.agent.cache.miss to monitor the
    cache

Closes #8649

This patch adds a new /agent/v1/metrics that will return metrics on the
running Vault agent. Configuration is done using the same telemetry
stanza than the Vault server. For now default runtime metrics are
returned with a few additional ones specific to the agent:
  - `vault.agent.auth.failure` and `vault.agent.auth.success` to monitor
  the correct behavior of the auto auth mechanism
  - `vault.agent.proxy.success`, `vault.agent.proxy.client_error` and
  `vault.agent.proxy.error` to check the connection with the Vault server
  - `vault.agent.cache.hit` and `vault.agent.cache.miss` to monitor the
  cache

Closes hashicorp#8649
@remilapeyre remilapeyre requested a review from a team January 16, 2022 14:26
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 16, 2022 14:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 16, 2022 14:27 Inactive
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions so far. Looks really good!

@tvoran tvoran added this to the 1.10 milestone Feb 17, 2022
@tvoran
Copy link
Member

tvoran commented Feb 18, 2022

Since it's just small suggestions, I'll be pushing up the changes shortly so we can get this in for 1.10.

@vercel vercel bot temporarily deployed to Preview – vault-storybook February 18, 2022 00:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 18, 2022 00:48 Inactive
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for putting this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add telemetry to vault agent
3 participants