-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry to Vault agent #13675
Add telemetry to Vault agent #13675
Conversation
This patch adds a new /agent/v1/metrics that will return metrics on the running Vault agent. Configuration is done using the same telemetry stanza than the Vault server. For now default runtime metrics are returned with a few additional ones specific to the agent: - `vault.agent.auth.failure` and `vault.agent.auth.success` to monitor the correct behavior of the auto auth mechanism - `vault.agent.proxy.success`, `vault.agent.proxy.client_error` and `vault.agent.proxy.error` to check the connection with the Vault server - `vault.agent.cache.hit` and `vault.agent.cache.miss` to monitor the cache Closes hashicorp#8649
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small suggestions so far. Looks really good!
Since it's just small suggestions, I'll be pushing up the changes shortly so we can get this in for 1.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for putting this together!
This patch adds a new
/agent/v1/metrics
that will return metrics on therunning Vault agent. Configuration is done using the same telemetry
stanza than the Vault server. For now default runtime metrics are
returned with a few additional ones specific to the agent:
vault.agent.auth.failure
andvault.agent.auth.success
to monitorthe correct behavior of the auto auth mechanism
vault.agent.proxy.success
,vault.agent.proxy.client_error
andvault.agent.proxy.error
to check the connection with the Vault servervault.agent.cache.hit
andvault.agent.cache.miss
to monitor thecache
Closes #8649