Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on upper case in policy name #14670

Merged
merged 7 commits into from
Mar 24, 2022
Merged

Conversation

digivava
Copy link
Collaborator

Provides a warning when an upper case character is given in a policy name, as our current behavior of just lower-casing anything that comes in without telling anyone has caused some users confusion (see #13647).

@digivava digivava requested a review from a team March 23, 2022 18:03
command/policy_write.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 23, 2022 18:29 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 23, 2022 18:29 Inactive
command/policy_write.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 23, 2022 20:39 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 23, 2022 20:39 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 23, 2022 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 23, 2022 20:45 Inactive
vault/logical_system.go Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault March 23, 2022 22:10 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 23, 2022 22:10 Inactive
Copy link
Contributor

@VinnyHC VinnyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment about order of operations.

command/policy_write.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault March 23, 2022 22:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 23, 2022 22:22 Inactive
command/policy_write.go Outdated Show resolved Hide resolved
command/policy_write.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault March 24, 2022 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 24, 2022 17:28 Inactive
Copy link
Contributor

@AnPucel AnPucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@VinnyHC VinnyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants