VAULT-5422: Add rate limit for TOTP passcode attempts #14864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hghaf099
commented
Apr 3, 2022
raskchanky
reviewed
Apr 5, 2022
mickael-hc
reviewed
Apr 5, 2022
raskchanky
reviewed
Apr 13, 2022
raskchanky
approved these changes
Apr 13, 2022
hghaf099
added a commit
that referenced
this pull request
Apr 14, 2022
* VAULT-5422: Add rate limit for TOTP passcode attempts * fixing the docs * CL * feedback * Additional info in doc * rate limit is done per entity per methodID * refactoring a test * rate limit OSS work for policy MFA * adding max_validation_attempts to TOTP config * feedback * checking for non-nil reference
hghaf099
added a commit
that referenced
this pull request
Apr 15, 2022
* VAULT-5422: Add rate limit for TOTP passcode attempts (#14864) * VAULT-5422: Add rate limit for TOTP passcode attempts * fixing the docs * CL * feedback * Additional info in doc * rate limit is done per entity per methodID * refactoring a test * rate limit OSS work for policy MFA * adding max_validation_attempts to TOTP config * feedback * checking for non-nil reference * remove WithContext functions from a test
kitography
pushed a commit
that referenced
this pull request
Apr 24, 2022
* VAULT-5422: Add rate limit for TOTP passcode attempts * fixing the docs * CL * feedback * Additional info in doc * rate limit is done per entity per methodID * refactoring a test * rate limit OSS work for policy MFA * adding max_validation_attempts to TOTP config * feedback * checking for non-nil reference
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
* VAULT-5422: Add rate limit for TOTP passcode attempts * fixing the docs * CL * feedback * Additional info in doc * rate limit is done per entity per methodID * refactoring a test * rate limit OSS work for policy MFA * adding max_validation_attempts to TOTP config * feedback * checking for non-nil reference
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
* VAULT-5422: Add rate limit for TOTP passcode attempts * fixing the docs * CL * feedback * Additional info in doc * rate limit is done per entity per methodID * refactoring a test * rate limit OSS work for policy MFA * adding max_validation_attempts to TOTP config * feedback * checking for non-nil reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are adding a rate limit to the totp passcode validation. The default allowed number of totp failed passcode validations is set to 5. If the number of failed validations attempts exceeds the configured amount, the user is blocked for the amount of time equal to the totp period configuration. There is no backdoor process to reset the counter right now. If needed that could be added as well.
Addresses VAULT-5422