Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings indicating ignored and replaced parameters #14962

Merged
merged 9 commits into from
Apr 11, 2022
Merged

Warnings indicating ignored and replaced parameters #14962

merged 9 commits into from
Apr 11, 2022

Commits on Apr 7, 2022

  1. Warnings indicating ignored and replaced parameters

    @vishalnayak
    vishalnayak committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    e1b72d5 View commit details
    Browse the repository at this point in the history

  2. Avoid additional var creation

    @vishalnayak
    vishalnayak committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    6e6d17c View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Add warnings only if the response is non-nil

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    6193f17 View commit details
    Browse the repository at this point in the history

  2. Return the response even when error is non-nil

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    7c0d32f View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    16affaa View commit details
    Browse the repository at this point in the history

  4. Rearrange comments

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    36dc78d View commit details
    Browse the repository at this point in the history

  5. Print warning in the log

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    b33cac9 View commit details
    Browse the repository at this point in the history

  6. Fix another test

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c46de65 View commit details
    Browse the repository at this point in the history

  7. Add CL

    @vishalnayak
    vishalnayak committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    a683903 View commit details
    Browse the repository at this point in the history