Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/merge main #14997

Merged
merged 44 commits into from
Apr 11, 2022
Merged

UI/merge main #14997

merged 44 commits into from
Apr 11, 2022

Commits on Apr 1, 2022

  1. Vault documentation: changing references from learn to tutorial (#14844)

    * changed learn to tutorial references
    
    * changed learn to tutorial
    
    * Update website/content/docs/plugins/plugin-portal.mdx
    
    Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
    
    * Update website/content/docs/platform/aws/run.mdx
    
    Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
    
    Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
    taoism4504 and yhyakuna authored Apr 1, 2022
    Configuration menu
    Copy the full SHA
    e53aedd View commit details
    Browse the repository at this point in the history
  2. UI/Only show form values if have read access (#14794)

    * only show value in edit form if has read capabilities
    
    * revert messing with form
    
    * delete secret data from secret
    
    * add check for selected version
    
    * remove added line
    
    * add changelog
    hellobontempo authored Apr 1, 2022
    Configuration menu
    Copy the full SHA
    cf44b62 View commit details
    Browse the repository at this point in the history
  3. modified text (#14854)

    taoism4504 authored Apr 1, 2022
    Configuration menu
    Copy the full SHA
    7dc8b43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    931562e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1bde37c View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Vault 3999 Change permissions for directory/archive created by debug …

    …command (#14846)
    
    * adding debug changes from ent
    
    * adding changelog
    akshya96 authored Apr 4, 2022
    Configuration menu
    Copy the full SHA
    59451c2 View commit details
    Browse the repository at this point in the history
  2. Vault 3992 ToB Config and Plugins Permissions (#14817)

    * updating changes from ent PR
    
    * adding changelog
    
    * fixing err
    
    * fixing semgrep error
    akshya96 authored Apr 4, 2022
    Configuration menu
    Copy the full SHA
    8352661 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    93472f3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    10833d4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e249005 View commit details
    Browse the repository at this point in the history
  6. Fix handling of default zero SignatureBits value with Any key type in…

    … PKI Secrets Engine (#14875)
    
    * Correctly handle minimums, default SignatureBits
    
    When using KeyType = "any" on a role (whether explicitly or implicitly
    via a sign-verbatim like operation), we need to update the value of
    SignatureBits from its new value 0 to a per-key-type default value. This
    will allow sign operations on these paths to function correctly, having
    the correctly inferred default signature bit length.
    
    Additionally, this allows the computed default value for key type to be
    used for minimum size validation in the RSA/ECDSA paths. We additionally
    enforce the 2048-minimum in this case as well.
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    
    * Fix defaults and validation of "any" KeyType
    
    When certutil is given the placeholder any keytype, it attempts to
    validate and update the default zero value. However, in lacking a
    default value for SignatureBits, it cannot update the value from the
    zero value, thus causing validation to fail.
    
    Add more awareness to the placeholder "any" value to certutil.
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    
    * Add role-based regression tests for key bits
    
    This adds regression tests for Key Type, Key Bits, and Signature Bits
    parameters on the role. We test several values, including the "any"
    value to ensure it correctly restricts key sizes.
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    
    * Add sign-verbatim test for key type
    
    This ensures that we test sign-verbatim against a variety of key types.
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    
    * Add changelog entry
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    
    Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
    cipherboy and stevendpclark authored Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7d92a63 View commit details
    Browse the repository at this point in the history
  7. Subtle docs change for allow_store_key (#14889)

    * Subtle docs change for allow_store_key
    
    * errant space
    sgmiller authored Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7aef98e View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Configuration menu
    Copy the full SHA
    3cf641c View commit details
    Browse the repository at this point in the history
  2. docs: fix formatting on plugin upgrade page (#14874)

    * docs: fix formatting on plugin upgrade page
    
    * fix more formatting issues
    fairclothjm authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f90e139 View commit details
    Browse the repository at this point in the history
  3. Update CC docs (#14714)

    * Update CC docs
    
    * Add sample response
    
    * Address review feedback
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Meggie <meggie@hashicorp.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Update website/content/api-docs/system/internal-counters.mdx
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    
    * Minor edits
    
    * Update partial month API
    
    Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
    Co-authored-by: Meggie <meggie@hashicorp.com>
    3 people authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    99e202d View commit details
    Browse the repository at this point in the history
  4. Docs improvements for Managed Keys (#14756)

    * Add more color around managed keys in their concepts page, and create additional links between
    the various docs pages related to them.
    
    * Typos
    sgmiller authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d537c2e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98bb642 View commit details
    Browse the repository at this point in the history
  6. clean up (#14911)

    Monkeychip authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    e23ff1b View commit details
    Browse the repository at this point in the history
  7. website: fix usages of img tag (#14910)

    * fix usages of img tag and integrate dev-portal workflows
    
    * Adjust Makefile
    Bryce Kalow authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    561a2ee View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Configuration menu
    Copy the full SHA
    64ba057 View commit details
    Browse the repository at this point in the history
  2. Add extra test coverage to PKI (#14767)

    * Add PKI test for delete role
    
     - Create a role, validate that defaults are what we expect
       and delete the role, verifying it is gone on subsequent read
       attempts.
    
    * Add PKI test for crl/rotate command
    
     - Missing a unit test that validates the crl/rotate command works. The test validates the rotate command was successful
       by checking if we have a different/new update time on the CRL.
    
    * Rework PKI TestBackend_PathFetchValidRaw test to not write directly to storage
    
     - Rework the existing test to not write directly to storage as we might change that in the future.
     - Add tests that validate the ca_chain behaviour of not returning the root authority cert
    
    * PR Feedback
    
    * Additional PR feedback
    stevendpclark authored Apr 6, 2022
    Configuration menu
    Copy the full SHA
    16a23cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d520d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    18ee7d9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9c6d25a View commit details
    Browse the repository at this point in the history
  6. Mount flag syntax to mitigate confusion from KV-v2 path discrepancies (

    …#14807)
    
    * Add explanation to help text and flag usage text
    
    * KV get with new mount flag
    
    * Clearer naming
    
    * KV Put, Patch, Metadata Get + corresponding tests
    
    * KV Delete, Destroy, Rollback, Undelete, MetadataDelete, MetadataPatch, MetadataPut
    
    * Update KV-v2 docs to use mount flag syntax
    
    * Add changelog
    
    * Run make fmt
    
    * Clarify deprecation message in help string
    
    * Address style comments
    digivava authored Apr 6, 2022
    Configuration menu
    Copy the full SHA
    74248e1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    601acf5 View commit details
    Browse the repository at this point in the history
  8. docs: added hello-vault-spring repo link to developer-qs.mdx. (#14928)

    * Update developer-qs.mdx
    
    docs: added link to Java / Spring Boot sample app repo in developer quick start.
    
    * removed space.
    
    * trigger ci
    
    Co-authored-by: taoism4504 <loann@hashicorp.com>
    mryan-hashi and taoism4504 authored Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3b34ab8 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. OIDC Login Bug (#14916)

    * fixes issue logging in with oidc from listed auth path tab
    
    * adds changelog entry
    
    * adds more tests for oidc auth workflow
    
    * updates oidc auth method test to use non-standard path
    zofskeez authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    df30e05 View commit details
    Browse the repository at this point in the history
  2. Fix handling of SignatureBits for ECDSA issuers (#14943)

    When adding SignatureBits control logic, we incorrectly allowed
    specification of SignatureBits in the case of an ECDSA issuer. As noted
    in the original request, NIST and Mozilla (and others) are fairly
    prescriptive in the choice of signatures (matching the size of the
    NIST P-curve), and we shouldn't usually use a smaller (or worse, larger
    and truncate!) hash.
    
    Ignore the configuration of signature bits and always use autodetection
    for ECDSA like ed25519.
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    cipherboy authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    ca45941 View commit details
    Browse the repository at this point in the history
  3. Bug Fix and Glimmerize secret-edit component (#14941)

    * inital glimmerize
    
    * wip
    
    * wip
    
    * wip
    
    * fix maybeQueryRecord
    
    * fix
    
    * fix
    
    * fix test
    
    * cleanup
    
    * add changelog
    
    * clean up
    Monkeychip authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    55afadf View commit details
    Browse the repository at this point in the history
  4. Agent error log level is mismatched (#14424)

    * [VAULT-1618] Agent error log level is mismatched
    
    `logLevelToStringPtr` translates `go-hclog`'s `ERROR` to `"ERROR"` for
    Consul Template's runner, but that expects `ERR` and is quite strict
    about it.
    
    This will address hashicorp/vault-k8s#223
    after it is set as the default image in `vault-k8s`.
    
    I didn't find a simple way to test this other than starting up a full
    server and agent and letting them run, which is unfortunately fairly
    slow.
    
    I confirmed that this addresses the original issue by modifying the helm
    chart with the values in this commit and patching the log level to `err`.
    
    * VAULT-1618 Add changelog/14424.txt
    
    * VAULT-1618 Update changelog/14424.txt based on @kalafut suggestion
    
    Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
    
    * VAULT-1618 Move cancel and server stop into defer in tests
    
    * VAULT-1618 Triggering CircleCI tests
    
    * VAULT-1618 Replace ioutil with os functions for agent template tests
    
    Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
    swenson and Jim Kalafut authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    311910b View commit details
    Browse the repository at this point in the history
  5. UI/Add months to activity serializer (#14942)

    * add mock monthly data to mirage handler
    
    * add months to serializer for activity response
    
    * change selectors
    
    Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
    
    * clean up serializer
    
    * please stop being flakey <3
    
    Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
    hellobontempo and hashishaw authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    48b43e9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7b5b2a View commit details
    Browse the repository at this point in the history
  7. adding env var (#14958)

    akshya96 authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    c22a584 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    33e5b32 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Don't clone OutputCurlString value (#14968)

    * Don't clone OutputCurlString value, add flag to docs
    
    * Add changelog
    digivava authored Apr 8, 2022
    Configuration menu
    Copy the full SHA
    ec1a3cf View commit details
    Browse the repository at this point in the history
  2. Ensure initialMmapSize is 0 on Windows (#14977)

    * ensure initialMmapSize is 0 on windows
    
    * add changelog
    raskchanky authored Apr 8, 2022
    Configuration menu
    Copy the full SHA
    bacfe5a View commit details
    Browse the repository at this point in the history
  3. Vault 3992 documentation changes (#14918)

    * doc changes
    
    * adding config changes
    
    * adding chnages to plugins
    
    * using include
    
    * making doc changes
    
    * adding newline
    akshya96 authored Apr 8, 2022
    Configuration menu
    Copy the full SHA
    76ed511 View commit details
    Browse the repository at this point in the history
  4. aws auth displayName (#14954)

    * set displayName to include RoleSessionName
    jlestrada authored Apr 8, 2022
    Configuration menu
    Copy the full SHA
    5f4e32e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f258885 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Warnings indicating ignored and replaced parameters (#14962)

    * Warnings indicating ignored and replaced parameters
    
    * Avoid additional var creation
    
    * Add warnings only if the response is non-nil
    
    * Return the response even when error is non-nil
    
    * Fix tests
    
    * Rearrange comments
    
    * Print warning in the log
    
    * Fix another test
    
    * Add CL
    vishalnayak authored Apr 11, 2022
    Configuration menu
    Copy the full SHA
    fd73653 View commit details
    Browse the repository at this point in the history
  2. Fix edit capabilities call in auth method (#14966)

    * Fix edit capabilities call in auth method
    
    - Capabilities call was not getting triggered correctly as apiPath
      method was missing the correct context.
    
    * Added changelog
    arnav28 authored Apr 11, 2022
    Configuration menu
    Copy the full SHA
    361b213 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e94e0d View commit details
    Browse the repository at this point in the history
  4. make linting fix

    Monkeychip committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    dd65dc3 View commit details
    Browse the repository at this point in the history