fix regression on Core.pluginDirectory when backend is builtin #15027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
approved these changes
Apr 13, 2022
|
We should backport this all the way to 1.8.x as well. |
|
Is there a good way to add a test for this regression? |
@swenson I think it is a good idea. I will look into that. |
fairclothjm
changed the title
@calvn Looks like those backports were either closed or reverted. |
swenson
approved these changes
Apr 14, 2022
calvn
approved these changes
Apr 14, 2022
kitography
pushed a commit
that referenced
this pull request
Apr 24, 2022
* fix dev-plugin-dir when backend is builtin * use builtinRegistry.Contains * revert aa76337 * use correct plugin type for logical backend after revert * fix factory func default setting after revert * add ut coverage for builtin plugin with plugin directory set * add coverage for secrets plugin type * use totp in tests to avoid test import cycle in ssh package * use nomad in tests to avoid test import cycle * remove secrets mount tests due to unavoidable test import cycle
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
* fix dev-plugin-dir when backend is builtin * use builtinRegistry.Contains * revert aa76337 * use correct plugin type for logical backend after revert * fix factory func default setting after revert * add ut coverage for builtin plugin with plugin directory set * add coverage for secrets plugin type * use totp in tests to avoid test import cycle in ssh package * use nomad in tests to avoid test import cycle * remove secrets mount tests due to unavoidable test import cycle
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
* fix dev-plugin-dir when backend is builtin * use builtinRegistry.Contains * revert aa76337 * use correct plugin type for logical backend after revert * fix factory func default setting after revert * add ut coverage for builtin plugin with plugin directory set * add coverage for secrets plugin type * use totp in tests to avoid test import cycle in ssh package * use nomad in tests to avoid test import cycle * remove secrets mount tests due to unavoidable test import cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression on
Core.pluginDirectory. When enabling a secrets/auth plugin, vault looks in theCore.pluginDirectoryif thedev-plugin-dirflag orplugin_directoryconfig is set and fails if it doesn’t find it.The following error would occur when the
dev-plugin-dirflag orplugin_directoryconfig was set on a vault server: