When running under systemd, send ready when server completed reloading config #7028

[archaron]

Server must call SdNotifyReady when it completed reloading. Otherwise systemd gets timeout after vault service reload as mentioned in #7028.

[hashicorp-cla]

All committers have signed the CLA.

[jdoss]

This does work with reload but for some reason reload-or-restart does not work:

# systemctl status step-renew-cert@vault.service
× step-renew-cert@vault.service - Renew smallstep TLS cert and reload the service for vault
     Loaded: loaded (/etc/systemd/system/step-renew-cert@.service; disabled; vendor preset: disabled)
     Active: failed (Result: exit-code) since Tue 2022-05-03 00:15:51 CDT; 1min 40s ago
    Process: 966501 ExecStartPre=step ca root /etc/vault/tls/vault-ca.crt --force (code=exited, status=0/SUCCESS)
    Process: 966545 ExecStartPre=chown vault:vault /etc/vault/tls/vault-ca.crt (code=exited, status=0/SUCCESS)
    Process: 966547 ExecStart=step ca renew /etc/vault/tls/vault.crt /etc/vault/tls/vault.key --force (code=exited, status=0/SUCCESS)
    Process: 966602 ExecStartPost=chown vault:vault /etc/vault/tls/vault.crt /etc/vault/tls/vault.key (code=exited, status=0/SUCCESS)
    Process: 966604 ExecStartPost=systemctl reload-or-restart vault.service (code=exited, status=1/FAILURE)
   Main PID: 966547 (code=exited, status=0/SUCCESS)
        CPU: 105ms

[jdoss]

Nevermind! I guess sd_notify doesn't support reload-or-restart. https://www.freedesktop.org/software/systemd/man/sd_notify.html

[ncabatoff]

Fixes #15221.

[ncabatoff]

Thanks @archaron !