sort list of unrecognized params in response warning #15073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swayne275
approved these changes
Apr 18, 2022
raskchanky
approved these changes
Apr 18, 2022
kitography
pushed a commit
that referenced
this pull request
Apr 24, 2022
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
TestBackendHandleRequestFieldWarningsis flaky based on the order of the unrecognized params in the response warning. This PR introducing sorting for the list of params which provides a potentially improved UX but also fixes the test.