Allow fetching the specified issuer's CRL #15118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
cipherboy-per-issuer-crls
branch
from
4769411 to
dda9368
Compare
cipherboy
commented
Apr 21, 2022
| fields = addIssuerRefNameFields(fields) | ||
|
|
||
| return &framework.Path{ | ||
| // Returns raw values. |
There was a problem hiding this comment.
Is there value in perhaps adding a JSON equivalent (like /certs/crl) here too, for anyone using the CLI?
There was a problem hiding this comment.
Let's do this in another PR.
cipherboy
force-pushed
the
cipherboy-per-issuer-crls
branch
from
dda9368 to
5a3b0ce
Compare
stevendpclark
approved these changes
Apr 21, 2022
We add a new API endpoint to fetch the specified issuer's CRL directly (rather than the default issuer's CRL at /crl and /certs/crl). We also add a new test to validate the CRL in a multi-root scenario and ensure it is signed with the correct keys. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-per-issuer-crls
branch
from
5a3b0ce to
39f8606
Compare
|
Manually merged, thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new API endpoint to fetch the specified issuer's CRL directly
(rather than the default issuer's CRL at
/crland/certs/crl).Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>This adds the test cases that validate #15100 (ish, obviously we'll want more thorough ones but this should get us started). I'll rebase this one once that one merges.