Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release/1.8.x deploy previews #15159

Closed
wants to merge 4 commits into from

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Apr 25, 2022

same work as #15157

Bryce Kalow added 2 commits April 25, 2022 12:37
* fix usages of img tag and integrate dev-portal workflows

* Adjust Makefile
* fix usages of img tag and integrate dev-portal workflows

* Adjust Makefile
@thiskevinwang thiskevinwang requested a review from a team April 25, 2022 16:45
@thiskevinwang thiskevinwang changed the title Fix release 1 8 x previews fix release/1.8.x deploy previews Apr 25, 2022
@mladlow
Copy link
Collaborator

mladlow commented Apr 25, 2022

It looks like this PR brought in a change to circle which is preventing 1.8 builds from running. We need to fix that before this PR can be merged. Semgrep doesn't seem to exist in the 1.8 circle configs.

@thiskevinwang
Copy link
Contributor Author

Thanks @mladlow, I wasn't sure about that during cherrypicking merge conflicts. Removed semgrep in 97c7ac0

@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 7, 2023
@stevendpclark
Copy link
Contributor

Closing, we no longer use CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants