Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-14990] Support retrieving kv secret paths with trailing spaces #15188

Merged
merged 7 commits into from
May 10, 2022

Conversation

AnPucel
Copy link
Contributor

@AnPucel AnPucel commented Apr 26, 2022

Currently you can create secret paths with trailing spaces with the api in KV. We sanitize those in the cli, which means you cannot retrieve the secret path you previously created.

  • Update the CLI to allow you to retrieve secret paths with trailing spaces: vault kv get "secret/test ". The trailing space will not be removed.

@AnPucel AnPucel requested a review from a team April 26, 2022 17:51
@AnPucel AnPucel changed the title Support retrieving kv secret paths with trailing spaces [VAULT-14990] Support retrieving kv secret paths with trailing spaces Apr 26, 2022
command/base_helpers.go Outdated Show resolved Hide resolved
command/base_helpers.go Outdated Show resolved Hide resolved
command/kv_get.go Outdated Show resolved Hide resolved
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much simpler solution, I like it!

command/kv_get.go Outdated Show resolved Hide resolved
@AnPucel AnPucel merged commit 9a7c692 into main May 10, 2022
@AnPucel AnPucel deleted the anpucel/KVSpaceBug branch June 6, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants