-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent/auto-auth: Add min_backoff
to set first backoff value
#15204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Apr 27, 2022
calvn
reviewed
Apr 27, 2022
calvn
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last doc comment, otherwise looks like it's good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new config to Agent's auto-auth.method's stanza:
min_backoff
.Agent's auto-auth has an initial hardcoded retry duration of 1 second, which grows after each failed retry. I'm making this value configurable because there may be instances you want to retry faster/slower. While writing this feature I found that the SDK client used by auto-auth has it's own built in retry logic. I disabled that retry logic (set MaxRetries to 0) because the auto-auth code has its own backoff function and we were effectively doubling our retry attempts.
Templating also relies on auto-auth and has it's own retry logic. I found an instance where Vault failed to get a token but the templating server tried to fetch secrets. This resulted in yet another variation of retries and more requests to Vault. To combat this, I synced the Template server's initial backoff value to that of auto-auths.
Example config: