Add suport for Consul service-identities and node-identities #15295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokens can now be generated with any combination of policies, roles, service identities, and node identities.
swenson
reviewed
May 5, 2022
calvn
reviewed
May 5, 2022
calvn
approved these changes
May 9, 2022
austingebauer
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebase of #10607
This adds Consul secrets engine support for node-identities and service-identities.
When writing a Vault role, you can specify node-identity or service-identity like so:
vault write consul/roles/serv-id-role service_identities="webserv-1:dc1"or
vault write consul/roles/node-id-role node_identities="client-1:dc1"You can specify multiple of each identity on a Vault role. Service-identities are semicolon-separated because you can have a list of datacenters, while node-identities are just comma-separated.
vault write consul/roles/serv-id-role service_identities="webserv-1:dc1,dc2,dc3;webserv-2;webserv-3:dc1"or
vault write consul/roles/node-id-role node_identities="client-1:dc1,client-2;client-3:dc2"Then to obtain a token from Consul, you simply give the role like normal:
vault read consul/creds/serv-id-rolevault read consul/creds/node-id-role