Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update CSI Provider command line arguments #15810

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Jun 6, 2022

Updates the website with the latest flags, and also make some other small improvements to help users link things together.

Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettjacobson
Copy link

@tomhjp I'd like to point out that maybe it is worth clarifying in these docs; these fields do NOT support quoted values. At least for sure the vault-addr and the vault-tls-ca-cert options do not. I am very used to quoting string value options on CLIs, but here they are NOT allowed. And the error messages gave no hints that this was my problem for 4 hours :( At least they are not allowed to be quoted in the extraArgs part of the Helm chart (hopefully the env way of setting these via helm chart will ship soon)

1 similar comment
@brettjacobson
Copy link

@tomhjp I'd like to point out that maybe it is worth clarifying in these docs; these fields do NOT support quoted values. At least for sure the vault-addr and the vault-tls-ca-cert options do not. I am very used to quoting string value options on CLIs, but here they are NOT allowed. And the error messages gave no hints that this was my problem for 4 hours :( At least they are not allowed to be quoted in the extraArgs part of the Helm chart (hopefully the env way of setting these via helm chart will ship soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr/no-changelog website Code changes specifically for the docs website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants