Update consul-template to latest for pkiCert fix #16087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we get the fix in hashicorp/consul-template#1590. I tested manually that this no longer causes `pkiCert` to get into an infinite failure loop when the cert expires.
calvn
reviewed
Jun 21, 2022
| @@ -295,6 +295,7 @@ require ( | |||
| github.com/hashicorp/logutils v1.0.0 // indirect | |||
| github.com/hashicorp/mdns v1.0.4 // indirect | |||
| github.com/hashicorp/serf v0.9.6 // indirect | |||
| github.com/hashicorp/vault/api/auth/kubernetes v0.1.0 // indirect | |||
There was a problem hiding this comment.
How come this is adding an indirect dep to vault, does go mod tidy clean this up?
There was a problem hiding this comment.
go mod tidy is what added this :)
There was a problem hiding this comment.
It looks like that dep was added to consul-template recently: hashicorp/consul-template#1580
There was a problem hiding this comment.
I wonder if we should add an explicit replace at the top of this file like the other hashicorp/vault/api deps?
replace github.com/hashicorp/vault/api/auth/kubernetes => ./api/auth/kubernetes
There was a problem hiding this comment.
Yeah I think this makes sense. Looks like we do this for userpass and approle too.
added 2 commits
June 24, 2022 14:33
|
Updated with official 0.29.1 fix, and updated docs. Please take another look. |
tvoran
reviewed
Jun 24, 2022
| @@ -295,6 +295,7 @@ require ( | |||
| github.com/hashicorp/logutils v1.0.0 // indirect | |||
| github.com/hashicorp/mdns v1.0.4 // indirect | |||
| github.com/hashicorp/serf v0.9.6 // indirect | |||
| github.com/hashicorp/vault/api/auth/kubernetes v0.1.0 // indirect | |||
There was a problem hiding this comment.
I wonder if we should add an explicit replace at the top of this file like the other hashicorp/vault/api deps?
replace github.com/hashicorp/vault/api/auth/kubernetes => ./api/auth/kubernetes
tvoran
approved these changes
Jun 24, 2022
calvn
approved these changes
Jun 24, 2022
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
added 2 commits
June 24, 2022 15:48
swenson
added a commit
that referenced
this pull request
Jun 27, 2022
cherry-picked c165363 Update consul-template to latest for pkiCert fix So that we get the fixes in hashicorp/consul-template#1590 and hashicorp/consul-template#1591. I tested manually that this no longer causes `pkiCert` to get into an infinite failure loop when the cert expires, and that the key and CA certificate are also accessible. Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
swenson
added a commit
that referenced
this pull request
Jun 27, 2022
cherry-picked c165363 Update consul-template to latest for pkiCert fix So that we get the fixes in hashicorp/consul-template#1590 and hashicorp/consul-template#1591. I tested manually that this no longer causes `pkiCert` to get into an infinite failure loop when the cert expires, and that the key and CA certificate are also accessible. Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Christopher Swenson <swenson@swenson.io> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we get the fix in hashicorp/consul-template#1590.
I tested manually that this no longer causes
pkiCertto get into aninfinite failure loop when the cert expires.