Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump secrets/azure to v0.14.0 #17180

Merged
merged 3 commits into from
Sep 19, 2022
Merged

bump secrets/azure to v0.14.0 #17180

merged 3 commits into from
Sep 19, 2022

Conversation

vinay-gopalan
Copy link
Contributor

Steps:

go get github.com/hashicorp/vault-plugin-secrets-azure@v0.14.0
go mod tidy

@vinay-gopalan vinay-gopalan requested a review from a team September 16, 2022 21:01
@austingebauer
Copy link
Contributor

austingebauer commented Sep 16, 2022 •
edited
Loading

I think we need a "changes" CL entry for the AAD graph code removal.

Something like:

```release-note:changes
secrets/azure: Removed deprecated AAD graph API support from the secrets engine.
```

austingebauer
austingebauer approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CL entry 👍

@vinay-gopalan
Copy link
Contributor Author

I think we need a "changes" CL entry for the AAD graph code removal.

Something like:

release-note:changes secrets/azure: Removed deprecated AAD graph API support from the secrets engine.

Good call, thanks! Added a changelog :)

austingebauer
austingebauer approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vinay-gopalan
Copy link
Contributor Author

@austingebauer for some reason the Changelog check GH Action does not like the label changes: https://github.com/hashicorp/vault/actions/runs/3083974784/jobs/4985696682. Should I be using a different one?

@austingebauer
Copy link
Contributor

@vinay-gopalan - Ah, looks like it's "change" instead of "changes". Might give that a shot!

@vinay-gopalan vinay-gopalan merged commit c6e0242 into main Sep 19, 2022
@vinay-gopalan vinay-gopalan deleted the update-secrets-azure-v0.14.0 branch September 19, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingebauer austingebauer austingebauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @austingebauer