-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more permissions for mkdir #17658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
cipherboy-attempt-fix-docker
branch
from
October 26, 2022 14:59
14d62ee
to
66e6ab1
Compare
cipherboy
changed the title
Use archive mode for copying source
Use more permissions for mkdir
Oct 26, 2022
ncabatoff
approved these changes
Oct 26, 2022
cipherboy
force-pushed
the
cipherboy-attempt-fix-docker
branch
2 times, most recently
from
October 26, 2022 15:35
8600744
to
6fcda98
Compare
ncabatoff
reviewed
Oct 26, 2022
ncabatoff
reviewed
Oct 26, 2022
cipherboy
force-pushed
the
cipherboy-attempt-fix-docker
branch
2 times, most recently
from
October 26, 2022 15:41
dd8476d
to
721b139
Compare
@ncabatoff Updated, we'll see if CI like this pass. |
ncabatoff
approved these changes
Oct 26, 2022
This appears to be due to a CI change that resulted in different user IDs between the host and the container image. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-attempt-fix-docker
branch
from
October 26, 2022 16:44
721b139
to
3774073
Compare
This was referenced Oct 26, 2022
ltcarbonell
pushed a commit
that referenced
this pull request
Oct 26, 2022
This appears to be due to a CI change that resulted in different user IDs between the host and the container image. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added a commit
that referenced
this pull request
Oct 28, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added a commit
that referenced
this pull request
Oct 31, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added a commit
that referenced
this pull request
Oct 31, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This was referenced Oct 31, 2022
stevendpclark
pushed a commit
that referenced
this pull request
Nov 30, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added a commit
that referenced
this pull request
Nov 30, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>