VAULT-9900: Log rotation for 'agent' and 'server' commands #18031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
November 11, 2022 21:39
ncabatoff
reviewed
Nov 25, 2022
ncabatoff
approved these changes
Nov 29, 2022
|
After this change, Vault panics when asked to enter recovery mode - #20396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to bring parity between Vault and Consul for
agentandservercommands in relation to logging.This PR builds on #17841 which allowed users to specify a log file path via config or CLI flag when using Vault agent.
The functionality now applies to agent and server commands, but also adds the ability to rotate files with some parameters which affect:
Big Kudos to the Consul team, who already had done the hard work writing this code.
Documentation has been updated to reflect the flags available in both of the commands.