Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate namespaces when historical and current month data are mixed #18452

Merged
merged 2 commits into from
Dec 17, 2022

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky added this to the 1.13.0-rc1 milestone Dec 16, 2022
@@ -161,6 +161,7 @@ func parseStartEndTimes(a *ActivityLog, d *framework.FieldData) (time.Time, time
return startTime, endTime, nil
}

// This endpoint is not used by the UI. The UI's "export" feature is entirely client-side.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 thank you for adding

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! Thanks for all the useful comments :)

@raskchanky raskchanky merged commit b8de2c2 into main Dec 17, 2022
@raskchanky raskchanky deleted the fix-dupe-namespaces branch December 17, 2022 00:02
AnPucel pushed a commit that referenced this pull request Jan 14, 2023
…xed (#18452)

* De-duplicate namespaces when historical and current month data are mixed

* add changelog
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
…xed (#18452)

* De-duplicate namespaces when historical and current month data are mixed

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants