UI/pki key workflow tests #18496
Merged
UI/pki key workflow tests #18496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hellobontempo
commented
Dec 20, 2022
•
hellobontempo
commented
- Adds tests to the pki key workflow
- fixes capabilities check in the pki/key model
- moves policy generators into a helper file
This reverts commit aed9bb9.
hashishaw
approved these changes
Jan 3, 2023
| @@ -70,6 +63,41 @@ module('Acceptance | pki workflow', function (hooks) { | |||
| await logout.visit(); | |||
| }); | |||
|
|
|||
| test('empty state messages are correct when PKI not configured', async function (assert) { | |||
| */ | ||
| await fillIn(SELECTORS.keyNameInput, 'new-name'); | ||
| await click(SELECTORS.keyCancelButton); | ||
| assert.strictEqual(this.model.keyName, 'test-key', 'Model attributes rolled back on cancel'); |
There was a problem hiding this comment.
We should assert that the keyName updated on input before we cancel, to verify it does change the model as expected
There was a problem hiding this comment.
It actually doesn't do this right now...which I discovered writing this test a couple weeks ago - I have a PR to fix.
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* wip tests * fix links * Revert "wip tests" This reverts commit aed9bb9. * wip tests * add policy generator * add workflow tests for key * change apostrophe -___- * fix workflow tests * add update to key form tests * fix capability check for read * finish tests * fix flash messages; * rename policy generator file, update tests
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* wip tests * fix links * Revert "wip tests" This reverts commit aed9bb9. * wip tests * add policy generator * add workflow tests for key * change apostrophe -___- * fix workflow tests * add update to key form tests * fix capability check for read * finish tests * fix flash messages; * rename policy generator file, update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.