Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PKI-CLI to docs #19669

Merged
merged 18 commits into from
Mar 30, 2023
Merged

Add PKI-CLI to docs #19669

merged 18 commits into from
Mar 30, 2023

Conversation

kitography
Copy link
Contributor

@kitography kitography commented Mar 22, 2023 •
edited by yhyakuna
Loading

@kitography kitography modified the milestones: 1.13.1, 1.14 Mar 22, 2023
cipherboy
cipherboy reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Lots of great stuff here, I think mostly its formatting nits and a few content suggestions.

website/content/docs/commands/pki/issue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/issue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/reissue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/reissue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/issue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/list-intermediates.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/reissue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/reissue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/verify-sign.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/verify-sign.mdx Outdated Show resolved Hide resolved
yhyakuna
yhyakuna reviewed Mar 22, 2023
View reviewed changes
website/content/docs/commands/pki/index.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/index.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/index.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/index.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/issue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/list-intermediates.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/reissue.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/pki/verify-sign.mdx Outdated Show resolved Hide resolved
kitography and others added 6 commits March 22, 2023 11:52
@kitography @yhyakuna
Update website/content/docs/commands/pki/verify-sign.mdx
7d377a5 
Title Code as Shell

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@kitography @yhyakuna
Update website/content/docs/commands/pki/reissue.mdx
b6d6abf 
Title More Code as Shell

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@kitography @yhyakuna
Update website/content/docs/commands/pki/list-intermediates.mdx
c66692e 
Title code block as shell

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@kitography @yhyakuna
Update website/content/docs/commands/pki/issue.mdx
b727661 
Title code-block as shell

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@kitography @yhyakuna
Apply suggestions from code review
aba94b3 
Label Code-Blocks as Shell-Session

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@kitography @cipherboy
Apply suggestions from code review
e2e62d2 
Comma and Period Changes.

Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
@kitography @cipherboy
Apply suggestions from code review
469aee4 
ascheels highlighting-1

Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
kitography and others added 3 commits March 27, 2023 13:38
@kitography
Fix highlighting throughout.
d1a57fc
@kitography @cipherboy
Update website/content/docs/commands/pki/list-intermediates.mdx
663aff0 
Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
@kitography @cipherboy
Update website/content/docs/commands/pki/reissue.mdx
301adac 
Clarifying note on why unknown fields might be there.

Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
@kitography @cipherboy
Update website/content/docs/commands/pki/reissue.mdx
4e7da1d 
cipherboy request

Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
cipherboy approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚢

@kitography kitography merged commit 262b043 into main Mar 30, 2023
@kitography kitography deleted the docs/pki-cli-addition branch March 30, 2023 11:31
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@stevendpclark stevendpclark Awaiting requested review from stevendpclark

@yhyakuna yhyakuna Awaiting requested review from yhyakuna

Assignees
No one assigned
Labels
docs pr/no-changelog
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@kitography @cipherboy @yhyakuna