Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undelete for mount paths that are deeper than one level #19811

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

nickryand
Copy link
Contributor

Fixes #19810.

This pulls over a small code snippet from kv_delete.go which allows the undelete command to properly handle KV-V2 mount paths that are more than one layer deep.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

* Pulled in a fix from kv_delete.go that adds partialPath to
  the mountPath to support paths that are multiple levels deep.
* Added undelete tests to validate that KV secrets can be successfully
  undeleted when mounted at a multi-level mount path.
* Added changelog txt file
@nickryand nickryand changed the title Fix undelete Fix undelete for mount paths that are deeper than one level Mar 28, 2023
changelog/19811.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made a small change to the changelog (I updated it to cli/kv to be more in line with other changes), but thanks for this! I'll be merging once everything passes. Appreciate the in-depth testing.

@VioletHynes VioletHynes merged commit b9b72ec into hashicorp:main Oct 31, 2023
83 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault CLI KV2 Undelete for Multi-level Paths fails
4 participants