Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial ACME new-nonce API #19822

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Initial ACME new-nonce API #19822

merged 2 commits into from
Mar 29, 2023

Conversation

stevendpclark
Copy link
Contributor

@stevendpclark stevendpclark commented Mar 29, 2023 •
edited
Loading

Initial ACME new-nonce API implementation.

Missing bits

✅ 204 no-content-type response status code for GET requests

  • rework tests to use proper Vault instance Will do outside of this PR.

@stevendpclark stevendpclark added this to the 1.14 milestone Mar 29, 2023
@stevendpclark stevendpclark requested review from kitography, cipherboy and a team March 29, 2023 17:13
cipherboy
cipherboy approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 !

@stevendpclark stevendpclark enabled auto-merge (squash) March 29, 2023 17:55
@stevendpclark stevendpclark merged commit ddb5db1 into main Mar 29, 2023
@stevendpclark stevendpclark deleted the stevendpclark/vault-14440-new-nonce branch March 29, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@kitography kitography Awaiting requested review from kitography

Assignees
No one assigned
Labels
pr/no-changelog secret/pki
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendpclark @cipherboy