Correct Issue browser-actions/setup-chrome #19876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcboudreau
force-pushed
the
marcboudreau/test-setup-chrome
branch
from
b4ae997
to
e8ed527
Compare
marcboudreau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the browser-actions/setup-chrome action would fail in the test-ui workflow job: https://github.com/hashicorp/vault/actions/runs/4575976373/jobs/8079513066
The problem was that an incorrect commit hash was being used. The proposed commit hash is the correct one and it was verified by temporarily removing the if condition on the test-ui job. This caused the job to execute in this branch: https://github.com/hashicorp/vault/actions/runs/4575747084/jobs/8078976210