Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix race condition in string generator helper into release/1.13.x #19900

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19875 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


A data race in vault/helper/random.(*StringGenerator).validateConfig() was exposed by new text coverage that was recently introduced.

WARNING: DATA RACE
Read at 0x00c005d77000 by goroutine 10158:
  github.com/hashicorp/vault/helper/random.(*StringGenerator).validateConfig()
      /home/circleci/go/src/github.com/hashicorp/vault/helper/random/string_generator.go:243 +0x3e6

and

Previous write at 0x000006f28ae0 by goroutine 10155:
  github.com/hashicorp/vault/helper/random.(*StringGenerator).validateConfig()
      /home/circleci/go/src/github.com/hashicorp/vault/helper/random/string_generator.go:238 +0x293

Failure: https://app.circleci.com/pipelines/github/hashicorp/vault/51983/workflows/d654323c-baa8-4985-9838-a4131f8900f5/jobs/607405/steps


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/VAULT-15010/fix-string-gen-race/brightly-knowing-asp branch 2 times, most recently from 2de4b5a to f166885 Compare March 31, 2023 15:20
@fairclothjm fairclothjm merged commit 8fc7490 into release/1.13.x Apr 17, 2023
@fairclothjm fairclothjm deleted the backport/VAULT-15010/fix-string-gen-race/brightly-knowing-asp branch April 17, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants