Backport of VAULT-14733: SegmentReader interface for reading activity log segments into release/1.11.x #20016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/miagilepner/VAULT-14733-split-pq-2/plainly-well-cat
branch
2 times, most recently
from
9c58510 to
adfbc62
Compare
|
|
miagilepner
force-pushed
the
backport/miagilepner/VAULT-14733-split-pq-2/plainly-well-cat
branch
from
0f33b09 to
4c052ac
Compare
#19934) * create a segment reader for activity log segment * fix imports * updates based on comments
miagilepner
force-pushed
the
backport/miagilepner/VAULT-14733-split-pq-2/plainly-well-cat
branch
from
4c052ac to
3caae09
Compare
…plit-pq-2/plainly-well-cat
peteski22
approved these changes
Apr 11, 2023
miagilepner
deleted the
backport/miagilepner/VAULT-14733-split-pq-2/plainly-well-cat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19934 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR adds a SegmentReader interface and an implementation to read segment files from storage for use in the activity log.
This makes it easier to allow new inputs (such as mock data) to the precomputed query worker.
Overview of commits