Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only log stopping rollback manager once #20041

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Only log stopping rollback manager once #20041

merged 1 commit into from
Apr 10, 2023

Commits on Apr 7, 2023

  1. Only log stopping rollback manager once 

    When testing the Rollback Manager's one-time invocation in Enterprise,
it was noticed that due to the channel being closed, we'd always hit
this case and thus spam logs rather quickly with this message.

Switch to a boolean flip to log this once, as it is not executed in
parallel and thus doesn't need a sync.Once.

This only affected anyone calling the test core's
StopAutomaticRollbacks() helper.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    d6d1247 View commit details
    Browse the repository at this point in the history