UI: PKI routes extend base Route #20179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiannaquach
reviewed
Apr 14, 2023
| @service secretMountPath; | ||
|
|
||
| model() { | ||
| return this.modelFor('issuers.issuer'); |
There was a problem hiding this comment.
This is so much better than extending the PkiIssuerRoute!
kiannaquach
reviewed
Apr 14, 2023
| setupController(controller, resolvedModel) { | ||
| super.setupController(controller, resolvedModel); | ||
| controller.breadcrumbs.push( | ||
|
|
||
| controller.breadcrumbs = [ |
There was a problem hiding this comment.
I had a question for my understanding. Previously we were pushing in the two breadcrumbs, but the new change is setting this to an array of breadcrumbs. Why are we doing that?
There was a problem hiding this comment.
Good question! Before, since we were extending the other route, it was first calling setupController on the extended route, which instantiated breadcrumbs on the controller. Then this route's setupController is called, which just pushes the new breadcrumbs to the parent's array. Hope that makes sense!
kiannaquach
reviewed
Apr 14, 2023
kiannaquach
approved these changes
Apr 14, 2023
hashishaw
force-pushed
the
ui/untangle-pki-routes
branch
from
3eafb4f
to
4287af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR untangles the routing for the PKI engine. Extending other routes was causing confusion and it wasn't clear why some routes were even extended. As part of this PR, all the PKI models using openAPI are also instantiated at the engine application route so that the models are hydrated and available for the rest of the engine.