Backport of sdk/ldap: update interface to use DialURL into release/1.12.x #20211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ldap-dialurl/secondly-driving-pangolin
branch
2 times, most recently
from
0795935
to
fbf9b5b
Compare
jasonodonnell
approved these changes
Apr 17, 2023
jasonodonnell
deleted the
backport/ldap-dialurl/secondly-driving-pangolin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20200 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
I recently merged #20144 which adds connection timeout configuration, however, this was causing race tests to fail since it was changing a package variable. To fix this, I've changed the LDAP interface to use the suggested
ldap.DialURLfunction instead of the deprecatedldap.Dialandldap.DialTLSfunctions.Overview of commits