Refactor reporter for unseal setup #20296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
requested review from
raskchanky,
miagilepner,
hghaf099,
akshya96 and
a team
ncabatoff
reviewed
Apr 21, 2023
| @@ -2362,6 +2365,11 @@ func (s standardUnsealStrategy) unseal(ctx context.Context, logger log.Logger, c | |||
| if err := c.setupAuditedHeadersConfig(ctx); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| if err := c.setupCensusAgent(); err != nil { | |||
| c.logger.Error("skipping reporting for nil agent", "error", err) | |||
There was a problem hiding this comment.
Won't this code run in ent as well? How do we know this is a "nil agent"?
There was a problem hiding this comment.
Good question. If setupCensusAgent errors out, the agent will be nil, so this assertion holds.
ncabatoff
approved these changes
Apr 21, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the OSS portion of https://github.com/hashicorp/vault-enterprise/pull/3952