Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requested generated secret example #20556

Merged
merged 4 commits into from
May 10, 2023
Merged

Add requested generated secret example #20556

merged 4 commits into from
May 10, 2023

Conversation

jonathanfrappier
Copy link
Contributor

@jonathanfrappier jonathanfrappier commented May 10, 2023 •
edited
Loading

🎟️ Jira ticket

🔍 Deploy preview kv-v1
🔍 Deploy preview kv-v2

  • Add request to show KV in conjunction with password policy/generated password.

@jonathanfrappier jonathanfrappier self-assigned this May 10, 2023
yhyakuna
yhyakuna reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since updating these pages, could you change test to shell-session please?

website/content/docs/secrets/kv/kv-v1.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kv/kv-v2.mdx Outdated Show resolved Hide resolved
jonathanfrappier and others added 2 commits May 10, 2023 17:30
@jonathanfrappier @yhyakuna
Update website/content/docs/secrets/kv/kv-v1.mdx
55c1d52 
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@jonathanfrappier @yhyakuna
Update website/content/docs/secrets/kv/kv-v2.mdx
4d58221 
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
yhyakuna
yhyakuna approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanfrappier jonathanfrappier merged commit 68744f8 into main May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhyakuna yhyakuna yhyakuna approved these changes

Assignees

@jonathanfrappier jonathanfrappier

Labels
docs pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanfrappier @yhyakuna