VAULT-14735: write mock activity log entity files #20702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
force-pushed
the
miagilepner/VAULT-14735-segment-writing-1
branch
from
7a6a785
to
3567ce6
Compare
miagilepner
force-pushed
the
miagilepner/VAULT-14735-segment-writing-2
branch
from
c16c574
to
8e9160d
Compare
miagilepner
force-pushed
the
miagilepner/VAULT-14735-segment-writing-1
branch
from
3567ce6
to
a50dfa8
Compare
Base automatically changed from
miagilepner/VAULT-14735-segment-writing-1
to
main
May 24, 2023 08:42
miagilepner
force-pushed
the
miagilepner/VAULT-14735-segment-writing-2
branch
from
8e9160d
to
2355aed
Compare
miagilepner
requested review from
mpalmi,
raskchanky,
banks,
hghaf099 and
akshya96
mpalmi
approved these changes
May 24, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for writing the entity data from the activity log data generation endpoint. The activity log's segment writing code needed to be refactored a bit to support force writing only entities.