Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add additional endpoints, remove non-protected endpoints into release/1.13.x #20762

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20669 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jonathanfrappier
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


🎟️ Jira ticket

🔍 Deploy preview

Description

  • sys/auth/:path/tune is listed
    sys/auth/:path/tune | GET, POST, DELETE | Manage the auth methods (enable, read, delete, and tune)
  • Removed - auth/token/create-orphan is not a root-protected endpoint.
  • Added missing / - There is a slash missing from sys/config/auditing/request-headers:name
  • Added - sys/config-ui is not a valid endpoint. This should be sys/config/ui/headers
  • Added - sys/config/ui/headers/:name
  • Removed - sys/internal/specs/openapi is not root protected!
  • Removed - sys/step-down is listed as root protected but is not
  • Added - sys/remount is root protected but missing from the table
  • Added - sys/storage/raft/snapshot-auto/config
  • Added - /sys/storage/raft/snapshot-auto/config/:name
  • Spot checked several verbs, including sys/raw which was pointed out as an example of being incorrect, but according to our documentation is correct in the table.

Update:

  • Added - sys/internal/inspect/router/
  • Already in table specific to endpoints requiring sudo - sys/leases
  • Opted to leave out since deprecated - sys/revoke-force/:prefix and sys/revoke-prefix/:prefix
  • Already in table - beyond scope of this specific doc for further explanation - auth/token/create

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/docs/fix-root-protected-paths-policies/singularly-immense-cowbird branch from e039164 to 603aab1 Compare May 24, 2023 21:33
@hashicorp-cla
Copy link

hashicorp-cla commented May 24, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • yhyakuna
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@yhyakuna
Copy link
Contributor

Closing this and track this with #20765

@yhyakuna yhyakuna closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants