Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transit import/export of hmac-only keys #20864

Merged
merged 4 commits into from
May 31, 2023
Merged

Fix transit import/export of hmac-only keys #20864

merged 4 commits into from
May 31, 2023

Commits on May 31, 2023

  1. Fix export of HMAC typed keys 

    When initially implemented, exporting HMAC keys resulted in returning
the unused, internal HMACKey value rather than the main Key value that
is used for HMAC operations.

This is a breaking change.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    539796e View commit details
    Browse the repository at this point in the history

  2. Consistently handle HMAC keys in keysutil 

    When generating HMAC-typed keys, set HMACKey = Key consistently, to
allow users of HMAC-typed keys to use them backwards compatibly.

Notably, this could discard the (unused) HMACKey field set today.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    deb37ba View commit details
    Browse the repository at this point in the history

  3. Add test proving export of HMAC keys work 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1a89040 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    513eef5 View commit details
    Browse the repository at this point in the history