UI: [VAULT-17365, VAULT-17613, VAULT-17614] Dashboard Secrets Engine Card Improvements #21604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiannaquach
changed the title
kiannaquach
commented
Jul 6, 2023
| @@ -0,0 +1,5 @@ | |||
| .dashboard { | |||
| .secrets-engines-table { | |||
There was a problem hiding this comment.
this was specific to the dashboard table so I didn't make this style a helper class. Adding this resolved the table border issue where borders were being cut off
Monkeychip
reviewed
Jul 6, 2023
ui/app/styles/core.scss
Outdated
| @@ -62,6 +62,7 @@ | |||
| @import './components/confirm'; | |||
| @import './components/console-ui-panel'; | |||
| @import './components/control-group'; | |||
| @import './components/dashboard'; | |||
There was a problem hiding this comment.
so technically these are only meant to correspond to a component called "dashboard". And it looks like you're using a route called Dashboard.
Maybe you and I can sync real quick on this. Ideally (I know you mentioned above about it not being a helper class) but it really doesn't make sense as a component class.
There was a problem hiding this comment.
synced with angel and will move dashboard route template to a component file if extra styling is needed!
Monkeychip
reviewed
Jul 6, 2023
Monkeychip
approved these changes
Jul 6, 2023
VioletHynes
added
the
hashicorp-contributed-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some small improvements to secret engine card based on design feedback