Introduce Experiment to Toggle Between Legacy Auditing Backends/EventLogger #21628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM! I love the approach of using an experiment to make it easy to test.
My understanding is that the experiment will be removed when this feature is released -- if that's not true, we should have some tests for turning this on. If it will be removed, no problem at all.
VioletHynes
added
the
hashicorp-contributed-pr
Correct, we have no intention of maintaining both approaches, so there's no need to keep the experiment flag. |
marcboudreau
deleted the
marcboudreau/VAULT-17772/experiments-toggle-auditing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an experiment that will allow the incremental addition of eventlogger-based implementation changes without impacting the code base until the legacy backend implementations can be completely removed to complete the migration.