Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix styling for username input when editing a user #21771

Conversation

malinac02
Copy link
Contributor

@malinac02 malinac02 commented Jul 11, 2023

Fix styling for username input when editing a user

Description:

  • With the userpass auth method, you can't edit an already existing username. If you click in the username input field, it is not editable. The problem was that the username input field looks editable due to its styling
  • Fix: Now the username field has styling so that it looks non editable
  • Note: The username input field is a readonly field. The original goal was to make this field look identical to a disabled input, but I spoke with design and the readonly field should instead look like the screenshot below. (In other words, this now looks different than the design in the Jira ticket!)
  • How to see this:
    • Access > Authentication Methods > Enable new method > Username & password
    • Create and save a new user
    • Edit the user
    • The username cannot be edited, and the styling matches that

Images:
Before:
Before

After:
After

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 11, 2023
@malinac02 malinac02 added the ui label Jul 11, 2023
@malinac02 malinac02 added this to the 1.15 milestone Jul 13, 2023
@malinac02 malinac02 marked this pull request as ready for review July 13, 2023 16:48
@malinac02 malinac02 merged commit b543d53 into main Jul 13, 2023
@malinac02 malinac02 deleted the ui/VAULT-15853/change-styling-for-username-input-when-editing-user branch July 13, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants