Backport of Vault 18005 plugin api lock status into release/1.14.x #22135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-18005-plugin-api-lock-status/singularly-actual-wallaby
branch
from
e384791
to
5f939eb
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-18005-plugin-api-lock-status/singularly-actual-wallaby
branch
from
85f7fcd
to
77762ac
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
ccapurso
approved these changes
Jul 31, 2023
|
CI Results: |
ccapurso
deleted the
backport/vault-18005-plugin-api-lock-status/singularly-actual-wallaby
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21925 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
The KMIP plugin starts its own listener for which requests are not routed through Vault. Requests to this listener are not subjected to API locking if the KMIP mount resides within a namespace that has been locked. This PR introduces the ability, via the
ExtendedSystemViewfor a plugin to determine if requests to it should be blocked based on the lock status of the namespace within it resides. A separate ENT PR will be opened that adds tests as they will require namespace functionality.Overview of commits